----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1265/#review3050 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On July 5, 2012, 1:35 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1265/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 1:35 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9094:3a907dece3ac > --------------------------- > Bus: Add a notion of layers to the buses > > This patch moves all flow control, arbitration and state information > into a bus layer. The layer is thus responsible for all the state > transitions, and for keeping hold of the retry list. Consequently the > layer is also responsible for the draining. > > With this change, the non-coherent and coherent bus are given a single > layer to avoid changing any temporal behaviour, but the patch opens up > for adding more layers. > > > Diffs > ----- > > src/mem/bus.hh 5f0321c03a26 > src/mem/bus.cc 5f0321c03a26 > src/mem/coherent_bus.hh 5f0321c03a26 > src/mem/coherent_bus.cc 5f0321c03a26 > src/mem/noncoherent_bus.hh 5f0321c03a26 > src/mem/noncoherent_bus.cc 5f0321c03a26 > > Diff: http://reviews.gem5.org/r/1265/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
