changeset 7e9e34d4203b in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=7e9e34d4203b
description:
stats: remove duplicate instruction stats from the commit stage
these stats are duplicates of insts/opsCommitted, cause
confusion, and are poorly named.
diffstat:
src/cpu/o3/commit.hh | 4 ----
src/cpu/o3/commit_impl.hh | 24 ++++++------------------
2 files changed, 6 insertions(+), 22 deletions(-)
diffs (62 lines):
diff -r d3772fe85fa6 -r 7e9e34d4203b src/cpu/o3/commit.hh
--- a/src/cpu/o3/commit.hh Tue Sep 11 17:47:21 2012 -0500
+++ b/src/cpu/o3/commit.hh Wed Sep 12 11:35:52 2012 -0400
@@ -447,10 +447,6 @@
/** Updates commit stats based on this instruction. */
void updateComInstStats(DynInstPtr &inst);
- /** Stat for the total number of committed instructions. */
- Stats::Scalar commitCommittedInsts;
- /** Stat for the total number of committed ops. */
- Stats::Scalar commitCommittedOps;
/** Stat for the total number of squashed instructions discarded by commit.
*/
Stats::Scalar commitSquashedInsts;
diff -r d3772fe85fa6 -r 7e9e34d4203b src/cpu/o3/commit_impl.hh
--- a/src/cpu/o3/commit_impl.hh Tue Sep 11 17:47:21 2012 -0500
+++ b/src/cpu/o3/commit_impl.hh Wed Sep 12 11:35:52 2012 -0400
@@ -161,14 +161,6 @@
DefaultCommit<Impl>::regStats()
{
using namespace Stats;
- commitCommittedInsts
- .name(name() + ".commitCommittedInsts")
- .desc("The number of committed instructions")
- .prereq(commitCommittedInsts);
- commitCommittedOps
- .name(name() + ".commitCommittedOps")
- .desc("The number of committed instructions")
- .prereq(commitCommittedInsts);
commitSquashedInsts
.name(name() + ".commitSquashedInsts")
.desc("The number of squashed insts skipped by commit")
@@ -998,16 +990,6 @@
// Set the doneSeqNum to the youngest committed instruction.
toIEW->commitInfo[tid].doneSeqNum = head_inst->seqNum;
- if (!head_inst->isMicroop() || head_inst->isLastMicroop())
- ++commitCommittedInsts;
- ++commitCommittedOps;
-
- // To match the old model, don't count nops and instruction
- // prefetches towards the total commit count.
- if (!head_inst->isNop() && !head_inst->isInstPrefetch()) {
- cpu->instDone(tid, head_inst);
- }
-
if (tid == 0) {
canHandleInterrupts = (!head_inst->isDelayedCommit()) &&
((THE_ISA != ALPHA_ISA) ||
@@ -1369,6 +1351,12 @@
instsCommitted[tid]++;
opsCommitted[tid]++;
+ // To match the old model, don't count nops and instruction
+ // prefetches towards the total commit count.
+ if (!inst->isNop() && !inst->isInstPrefetch()) {
+ cpu->instDone(tid, inst);
+ }
+
//
// Control Instructions
//
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
