----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1454/#review3586 -----------------------------------------------------------
configs/common/CacheConfig.py <http://reviews.gem5.org/r/1454/#comment3600> Although the overall patch looks good, I'm not to thrilled that all the default values now are moved to the Options.py file instead of being per "configuration" as in the O3_ARM_v7aL2 class. It would be better to not use the option unless it is explicitly set by the user. - Andreas Hansson On Oct. 23, 2012, 11:18 a.m., Lluís Vilanova wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1454/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2012, 11:18 a.m.) > > > Review request for Default. > > > Description > ------- > > Simplifies initial testing of different cache latency values with the example > scripts. > > > Diffs > ----- > > configs/common/CacheConfig.py f634a34f2f0b > configs/common/Options.py f634a34f2f0b > configs/ruby/MESI_CMP_directory.py f634a34f2f0b > configs/ruby/MI_example.py f634a34f2f0b > configs/ruby/MOESI_CMP_directory.py f634a34f2f0b > configs/ruby/MOESI_CMP_token.py f634a34f2f0b > configs/ruby/MOESI_hammer.py f634a34f2f0b > configs/ruby/Network_test.py f634a34f2f0b > > Diff: http://reviews.gem5.org/r/1454/diff/ > > > Testing > ------- > > > Thanks, > > Lluís Vilanova > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
