----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1523/ -----------------------------------------------------------
(Updated Oct. 30, 2012, 8:31 a.m.) Review request for Default. Description (updated) ------- Changeset 9356:a2d5d47de2bf --------------------------- TournamentBP: Fix some bugs with table sizes and counters globalHistoryBits, globalPredictorSize, and choicePredictorSize are decoupled. globalHistoryBits controls how much history is kept, global and choice predictor sizes control how much of that history is used when accessing predictor tables. This way, global and choice predictors can actually be different sizes, and it is no longer possible to walk off the predictor arrays and cause a seg fault. There are now individual thresholds for choice, global, and local saturating counters, so that taken/not taken decisions are correct even when the predictors' counters' sizes are different. The interface for localPredictorSize has been removed from TournamentBP because the value can be calculated from localHistoryBits. Diffs (updated) ----- configs/common/O3_ARM_v7a.py e71f71ce233a src/cpu/inorder/resources/bpred_unit.cc e71f71ce233a src/cpu/o3/bpred_unit_impl.hh e71f71ce233a src/cpu/pred/tournament.hh e71f71ce233a src/cpu/pred/tournament.cc e71f71ce233a Diff: http://reviews.gem5.org/r/1523/diff/ Testing ------- Works with ARM SE quick regression (except for dram target, which fails with and without this patch). Thanks, Erik Tomusk _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
