> On Nov. 6, 2012, 3:58 a.m., Andreas Hansson wrote: > > I'm curious about the testing statement. No regressions should be failing. > > Erik Tomusk wrote: > The tgen-simple-dram regression is failing for me even on a clean gem5 and > has been for a while. It goes through all my RAM (4GB), a good bit of swap > space, and then just hangs.
Hmm, how odd. It works fine on zizzer and my local machines (RHE5 and Ubuntu 10.04). What configuration are you running? Any chance you could give it a go with valgrind? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1523/#review3668 ----------------------------------------------------------- On Nov. 6, 2012, 4:03 a.m., Erik Tomusk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1523/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 4:03 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9387:38c52462af41 > --------------------------- > TournamentBP: Fix some bugs with table sizes and counters > globalHistoryBits, globalPredictorSize, and choicePredictorSize are decoupled. > globalHistoryBits controls how much history is kept, global and choice > predictor sizes control how much of that history is used when accessing > predictor tables. This way, global and choice predictors can actually be > different sizes, and it is no longer possible to walk off the predictor arrays > and cause a seg fault. > > There are now individual thresholds for choice, global, and local saturating > counters, so that taken/not taken decisions are correct even when the > predictors' counters' sizes are different. > > The interface for localPredictorSize has been removed from TournamentBP > because > the value can be calculated from localHistoryBits. > > > Diffs > ----- > > configs/common/O3_ARM_v7a.py 4229aedfdd09 > src/cpu/inorder/resources/bpred_unit.cc 4229aedfdd09 > src/cpu/o3/bpred_unit_impl.hh 4229aedfdd09 > src/cpu/pred/tournament.hh 4229aedfdd09 > src/cpu/pred/tournament.cc 4229aedfdd09 > > Diff: http://reviews.gem5.org/r/1523/diff/ > > > Testing > ------- > > Works with ARM SE quick regression (except for dram target, which fails > with and without this patch). > > ARM SE long regressions all pass when this patch is applied onto > changeset 9354. > > > Thanks, > > Erik Tomusk > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
