Hi Erik, There's currently no way of pruning parameters that are not used (besides creating subclasses which seems like an overkill in this case).
Andreas On 12/11/2012 13:35, "Erik Tomusk" <e.tom...@sms.ed.ac.uk> wrote: >localPredictorSize still shows up in config.ini even though it's not >used. The value is still required for the 2bit_local predictor, and I >haven't found a place in the code where I can specify that it should not >be listed for the tournament predictor. Any ideas? > >-Erik > >On 12/11/12 13:21, Andreas Hansson wrote: >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/1523/ >> >> >> Ship it! >> >> Ship It! >> >> - Andreas >> >> >> On November 12th, 2012, 5:18 a.m., Erik Tomusk wrote: >> >> Review request for Default. >> By Erik Tomusk. >> >> /Updated Nov. 12, 2012, 5:18 a.m./ >> >> >> Description >> >> Changeset 9388:1175213b3f61 >> --------------------------- >> TournamentBP: Fix some bugs with table sizes and counters >> globalHistoryBits, globalPredictorSize, and choicePredictorSize are >>decoupled. >> globalHistoryBits controls how much history is kept, global and choice >> predictor sizes control how much of that history is used when accessing >> predictor tables. This way, global and choice predictors can actually be >> different sizes, and it is no longer possible to walk off the predictor >>arrays >> and cause a seg fault. >> >> There are now individual thresholds for choice, global, and local >>saturating >> counters, so that taken/not taken decisions are correct even when the >> predictors' counters' sizes are different. >> >> The interface for localPredictorSize has been removed from TournamentBP >>because >> the value can be calculated from localHistoryBits. >> >> >> Testing >> >> Works with ARM SE quick regression (except for dram target, which fails >> with and without this patch). >> >> ARM SE long regressions all pass when version 6 of this patch is >> applied onto changeset 9385. >> >> >> Diffs >> >> * configs/common/O3_ARM_v7a.py (4229aedfdd09) >> * src/cpu/inorder/resources/bpred_unit.cc (4229aedfdd09) >> * src/cpu/o3/bpred_unit_impl.hh (4229aedfdd09) >> * src/cpu/pred/tournament.hh (4229aedfdd09) >> * src/cpu/pred/tournament.cc (4229aedfdd09) >> >> View Diff <http://reviews.gem5.org/r/1523/diff/> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
