> On Nov. 6, 2012, 5:25 a.m., Ali Saidi wrote: > > src/cpu/pred/tournament.cc, line 112 > > <http://reviews.gem5.org/r/1523/diff/5/?file=31001#file31001line112> > > > > could you switch these to use mask() instead af creating the mask > > yourself? It just makes it a bit clearer about what is going on. > > > > src/base/bitfields.hh > > > > > > Erik Tomusk wrote: > How should bitfields.hh be included in the build process? It's not > obvious to me how SCons finds headers. > > Ali Saidi wrote: > you should be able to include it with: > #include "base/bitfields.hh" > >
It was just a typo. - Erik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1523/#review3672 ----------------------------------------------------------- On Nov. 7, 2012, 3:24 a.m., Erik Tomusk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1523/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 3:24 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9387:942ab8031852 > --------------------------- > TournamentBP: Fix some bugs with table sizes and counters > globalHistoryBits, globalPredictorSize, and choicePredictorSize are decoupled. > globalHistoryBits controls how much history is kept, global and choice > predictor sizes control how much of that history is used when accessing > predictor tables. This way, global and choice predictors can actually be > different sizes, and it is no longer possible to walk off the predictor arrays > and cause a seg fault. > > There are now individual thresholds for choice, global, and local saturating > counters, so that taken/not taken decisions are correct even when the > predictors' counters' sizes are different. > > The interface for localPredictorSize has been removed from TournamentBP > because > the value can be calculated from localHistoryBits. > > > Diffs > ----- > > configs/common/O3_ARM_v7a.py 4229aedfdd09 > src/cpu/inorder/resources/bpred_unit.cc 4229aedfdd09 > src/cpu/o3/bpred_unit_impl.hh 4229aedfdd09 > src/cpu/pred/tournament.hh 4229aedfdd09 > src/cpu/pred/tournament.cc 4229aedfdd09 > > Diff: http://reviews.gem5.org/r/1523/diff/ > > > Testing > ------- > > Works with ARM SE quick regression (except for dram target, which fails > with and without this patch). > > ARM SE long regressions all pass when this patch is applied onto > changeset 9354. > > > Thanks, > > Erik Tomusk > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
