Hi Andreas,

Some problems with the reviewboars/patch, so I just discarded it/recreated
it. To answer your previous question though:

Apparently the directory (all in fact) controllers were children of
the 'System' object instead of the 'RubySystem' object. I updated the
patch so that they become part of ruby_system, and because the
Sequencer is a child of the L1 Controller, it inherits the RubySystem
clock period now. Also, the previous revision of this patch created a
add child warning: add_child('cpu_sequencers'): child 'sequencer
sequencer sequencer sequencer sequencer sequencer sequencer sequencer
sequencer sequencer sequencer sequencer sequencer sequencer sequencer
sequencer' already has parent: since the sequencer already had the L1
controller as a parent, and then I was reassigning it a new parent
'RubySystem'. This update fixes the warning.


Malek

On Fri, Jan 4, 2013 at 11:52 AM, Malek Musleh <[email protected]>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1596/
>   Review request for Default.
> By Malek Musleh.
> Description
>
> Changeset 9376:fba1eda1cb0f
> ---------------------------
> Config: Move Ruby Objs to RubySystem in obj hierarchy
>
> This patch moves the contollers to be children of the ruby_system instead of 
> 'system' under the python object hierarchy. This is so that these objects can 
> inherit some of the ruby_system's parameter values without resorting to 
> calling a global system pointer during run-time. The Ruby Objects should be 
> direct children of the ruby_system instead of the main system object.
>
> Testing:
>
>   Diffs
>
>    - configs/ruby/MESI_CMP_directory.py
>    (26ba525347fe980eda39e56fcb61e58c202402df)
>    - configs/ruby/MI_example.py (26ba525347fe980eda39e56fcb61e58c202402df)
>    - configs/ruby/MOESI_CMP_directory.py
>    (26ba525347fe980eda39e56fcb61e58c202402df)
>    - configs/ruby/MOESI_CMP_token.py
>    (26ba525347fe980eda39e56fcb61e58c202402df)
>    - configs/ruby/MOESI_hammer.py
>    (26ba525347fe980eda39e56fcb61e58c202402df)
>
> View Diff <http://reviews.gem5.org/r/1596/diff/>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to