----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1596/#review3798 -----------------------------------------------------------
I am not opposed to committing this patch. But I am not convinced if all the controllers should be under the object ruby_system. If we ever move to a system in which different controllers have different frequencies of operation, it seems that all the cache controllers private to a core would be more tightly bound to core, than being bound to memory system. - Nilay Vaish On Jan. 8, 2013, 9:43 a.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1596/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2013, 9:43 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9376:abfda926f810 > --------------------------- > config: Move Ruby Objs to RubySystem in obj hierarchy > > This patch moves the contollers to be children of the ruby_system instead of > 'system' under the python object hierarchy. This is so that these objects can > inherit some of the ruby_system's parameter values without resorting to > calling a global system pointer during run-time. The Ruby Objects should be > direct children of the ruby_system instead of the main system object. > > Testing: > > > Diffs > ----- > > configs/ruby/MESI_CMP_directory.py 26ba525347fe980eda39e56fcb61e58c202402df > configs/ruby/MI_example.py 26ba525347fe980eda39e56fcb61e58c202402df > configs/ruby/MOESI_CMP_directory.py > 26ba525347fe980eda39e56fcb61e58c202402df > configs/ruby/MOESI_CMP_token.py 26ba525347fe980eda39e56fcb61e58c202402df > configs/ruby/MOESI_hammer.py 26ba525347fe980eda39e56fcb61e58c202402df > configs/ruby/Network_test.py 26ba525347fe980eda39e56fcb61e58c202402df > > Diff: http://reviews.gem5.org/r/1596/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
