----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1602/#review3790 -----------------------------------------------------------
Ship it! Hi Nilay, Thanks for resurrecting this. In principle I have no issues, I just would like to make sure that the moved code includes all the latest fixes to the branch predictor that numerous people have contributed to. If so and you get no stats differences please commit. Thanks, Ali - Ali Saidi On Jan. 5, 2013, 9:20 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1602/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2013, 9:20 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9383:7a322ca1288f > --------------------------- > branch predictor: move out of o3 and inorder cpus > This patch moves the branch predictor files in the o3 and inorder directories > to src/cpu/pred. This allows sharing the branch predictor across different > cpu models. > > This patch was originally posted by Timothy Jones in July 2010 > but never made it to the repository. > > > Diffs > ----- > > configs/common/O3_ARM_v7a.py 36ed6d4654bb > src/cpu/BaseCPU.py 36ed6d4654bb > src/cpu/inorder/InOrderCPU.py 36ed6d4654bb > src/cpu/inorder/SConscript 36ed6d4654bb > src/cpu/inorder/inorder_cpu_builder.cc 36ed6d4654bb > src/cpu/inorder/resources/bpred_unit.hh 36ed6d4654bb > src/cpu/inorder/resources/bpred_unit.cc 36ed6d4654bb > src/cpu/inorder/resources/branch_predictor.hh 36ed6d4654bb > src/cpu/inorder/resources/branch_predictor.cc 36ed6d4654bb > src/cpu/o3/O3CPU.py 36ed6d4654bb > src/cpu/o3/SConscript 36ed6d4654bb > src/cpu/o3/bpred_unit.hh 36ed6d4654bb > src/cpu/o3/bpred_unit.cc 36ed6d4654bb > src/cpu/o3/bpred_unit_impl.hh 36ed6d4654bb > src/cpu/o3/cpu_policy.hh 36ed6d4654bb > src/cpu/o3/deriv.cc 36ed6d4654bb > src/cpu/o3/fetch.hh 36ed6d4654bb > src/cpu/o3/fetch_impl.hh 36ed6d4654bb > src/cpu/o3/sat_counter.hh 36ed6d4654bb > src/cpu/o3/sat_counter.cc 36ed6d4654bb > src/cpu/pred/2bit_local.hh 36ed6d4654bb > src/cpu/pred/2bit_local.cc 36ed6d4654bb > src/cpu/pred/BranchPredictor.py PRE-CREATION > src/cpu/pred/SConscript 36ed6d4654bb > src/cpu/pred/bpred_unit.hh PRE-CREATION > src/cpu/pred/bpred_unit.cc PRE-CREATION > src/cpu/pred/bpred_unit_impl.hh PRE-CREATION > src/cpu/pred/sat_counter.hh PRE-CREATION > src/cpu/pred/sat_counter.cc PRE-CREATION > src/cpu/pred/tournament.hh 36ed6d4654bb > src/cpu/pred/tournament.cc 36ed6d4654bb > > Diff: http://reviews.gem5.org/r/1602/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
