----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1615/#review3803 -----------------------------------------------------------
SConstruct <http://reviews.gem5.org/r/1615/#comment3693> No, it remains True, and thanks to that we do the CheckLib later and then decide if we got both or not. If we set PROTOC to False here then someone with a setup like Nilay (no pkg-config, but protobuf in the normal include and library path) would not be able to use it. - Andreas Hansson On Jan. 9, 2013, 9:18 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1615/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 9:18 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9460:45525a59768b > --------------------------- > scons: Allow pkg-config to fail and continue > > This patch changes the use of pkg-config such that protobuf is > disabled if the call to pkg-config is not successful. > > > Diffs > ----- > > SConstruct 8ca90cef0183 > > Diff: http://reviews.gem5.org/r/1615/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
