----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1615/#review3841 -----------------------------------------------------------
SConstruct <http://reviews.gem5.org/r/1615/#comment3707> I figured the concatenation done by the print is "safer", although protoc_version should always be a string. Anyone with stronger opinions on the Python style guide? - Andreas Hansson On Jan. 14, 2013, 2:42 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1615/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 2:42 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9464:b308039c9674 > --------------------------- > scons: Allow pkg-config to fail and continue > > This patch changes the use of pkg-config such that protobuf is > disabled if the call to pkg-config is not successful. > > > Diffs > ----- > > SConstruct 116396961ad1 > > Diff: http://reviews.gem5.org/r/1615/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
