----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1814/#review4203 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 7, 2013, 8:48 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1814/ > ----------------------------------------------------------- > > (Updated April 7, 2013, 8:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9631:910e75681f78 > --------------------------- > Sequencer: Delete packet requests during warmup > > When warming up caches in Ruby, the CacheRecorder sends fetch requests into > Ruby Sequencers with packet types that require responses. Since responses are > never generated for these CacheRecorder requests, the requests are not deleted > in the packet destructor called from the Ruby hit callback. Free the request. > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.cc fa31189e1fb5 > > Diff: http://reviews.gem5.org/r/1814/diff/ > > > Testing > ------- > > Tested with Valgrind to ensure that memory leaks are fixed. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
