----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1921/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9756:8956d858a9e6 --------------------------- ruby: restrict Address to being a type and not a variable name Change all occurrances of Address as a variable name to instead use Addr. Address is an allowed name in slicc even when Address is also being used as a type, leading to declarations of "Address Address". While this works, it prevents adding another field of type Address because the compiler then thinks Address is a variable name, not type. Diffs ----- src/mem/protocol/MESI_CMP_directory-L1cache.sm 9df73385c878 src/mem/protocol/MESI_CMP_directory-L2cache.sm 9df73385c878 src/mem/protocol/MESI_CMP_directory-dir.sm 9df73385c878 src/mem/protocol/MESI_CMP_directory-dma.sm 9df73385c878 src/mem/protocol/MESI_CMP_directory-msg.sm 9df73385c878 src/mem/protocol/MI_example-cache.sm 9df73385c878 src/mem/protocol/MI_example-dir.sm 9df73385c878 src/mem/protocol/MI_example-msg.sm 9df73385c878 src/mem/protocol/MOESI_CMP_directory-L1cache.sm 9df73385c878 src/mem/protocol/MOESI_CMP_directory-L2cache.sm 9df73385c878 src/mem/protocol/MOESI_CMP_directory-dir.sm 9df73385c878 src/mem/protocol/MOESI_CMP_directory-dma.sm 9df73385c878 src/mem/protocol/MOESI_CMP_directory-msg.sm 9df73385c878 src/mem/protocol/MOESI_CMP_token-L1cache.sm 9df73385c878 src/mem/protocol/MOESI_CMP_token-L2cache.sm 9df73385c878 src/mem/protocol/MOESI_CMP_token-dir.sm 9df73385c878 src/mem/protocol/MOESI_CMP_token-msg.sm 9df73385c878 src/mem/protocol/MOESI_hammer-cache.sm 9df73385c878 src/mem/protocol/MOESI_hammer-dir.sm 9df73385c878 src/mem/protocol/MOESI_hammer-msg.sm 9df73385c878 src/mem/protocol/Network_test-cache.sm 9df73385c878 src/mem/protocol/Network_test-dir.sm 9df73385c878 src/mem/protocol/Network_test-msg.sm 9df73385c878 src/mem/protocol/RubySlicc_MemControl.sm 9df73385c878 src/mem/ruby/system/RubyMemoryControl.cc 9df73385c878 Diff: http://reviews.gem5.org/r/1921/diff/ Testing ------- util/regress --builds="ALPHA_MOESI_hammer,ALPHA_MESI_CMP_directory,ALPHA_MOESI_CMP_directory,ALPHA_MOESI_CMP_token,X86_MESI_CMP_directory" --compile-variants="debug" --test-variants='fast' --modes="fs" Thanks, Lena Olson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
