----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1938/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 9802:5523750ec6fe --------------------------- scons: Move the warning about self assignment to SWIG code only This patch changes the gcc and clang flags such that the self-assignment warning is no longer globally disabled, and moves it to the SWIG flags. The instances where the warning causes problems are addressed as part of the patch. Note that this patch causes plenty warnings about uninitialised values, as we are currently hiding this with "int a; a = a;" constructs. Anyone brave enough (and skilled in the arts) should have a look and fix these. This affects X86, MIPS and SPARC. ALPHA and ARM work without any issues. Diffs ----- SConstruct 9cd5f91e7a79 src/SConscript 9cd5f91e7a79 src/arch/alpha/isa/branch.isa 9cd5f91e7a79 src/arch/arm/isa/formats/pred.isa 9cd5f91e7a79 src/arch/arm/isa/insts/ldr.isa 9cd5f91e7a79 src/arch/arm/isa/templates/macromem.isa 9cd5f91e7a79 src/arch/arm/isa/templates/pred.isa 9cd5f91e7a79 src/arch/mips/isa/decoder.isa 9cd5f91e7a79 src/arch/mips/isa/formats/branch.isa 9cd5f91e7a79 src/arch/power/isa/formats/branch.isa 9cd5f91e7a79 src/arch/sparc/isa/decoder.isa 9cd5f91e7a79 src/arch/sparc/isa/formats/branch.isa 9cd5f91e7a79 src/arch/x86/isa/decoder/two_byte_opcodes.isa 9cd5f91e7a79 src/arch/x86/isa/macroop.isa 9cd5f91e7a79 src/arch/x86/isa/microops/fpop.isa 9cd5f91e7a79 src/arch/x86/isa/microops/mediaop.isa 9cd5f91e7a79 src/arch/x86/isa/microops/regop.isa 9cd5f91e7a79 src/arch/x86/isa/microops/seqop.isa 9cd5f91e7a79 Diff: http://reviews.gem5.org/r/1938/diff/ Testing ------- ALPHA and ARM regressions pass, the other ISAs fail to compile due to uninitialised variables. Help to figure out what to do with these would be much appreciated. Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
