changeset 52679402e09c in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=52679402e09c
description:
        ruby: check for compatibility between mem size and num dirs
        The configuration scripts provided for ruby assume that the available
        physical memory is equally distributed amongst the directory 
controllers.
        But there is no check to ensure this assumption has been adhered to. 
This
        patch adds the required check.

diffstat:

 configs/ruby/MESI_CMP_directory.py  |  1 +
 configs/ruby/MI_example.py          |  1 +
 configs/ruby/MOESI_CMP_directory.py |  1 +
 configs/ruby/MOESI_CMP_token.py     |  1 +
 configs/ruby/MOESI_hammer.py        |  1 +
 configs/ruby/Network_test.py        |  1 +
 6 files changed, 6 insertions(+), 0 deletions(-)

diffs (66 lines):

diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/MESI_CMP_directory.py
--- a/configs/ruby/MESI_CMP_directory.py        Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/MESI_CMP_directory.py        Fri Jun 28 21:36:11 2013 -0500
@@ -142,6 +142,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     # Run each of the ruby memory controllers at a ratio of the frequency of
diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/MI_example.py
--- a/configs/ruby/MI_example.py        Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/MI_example.py        Fri Jun 28 21:36:11 2013 -0500
@@ -107,6 +107,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     # Run each of the ruby memory controllers at a ratio of the frequency of
diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/MOESI_CMP_directory.py
--- a/configs/ruby/MOESI_CMP_directory.py       Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/MOESI_CMP_directory.py       Fri Jun 28 21:36:11 2013 -0500
@@ -137,6 +137,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     # Run each of the ruby memory controllers at a ratio of the frequency of
diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/MOESI_CMP_token.py
--- a/configs/ruby/MOESI_CMP_token.py   Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/MOESI_CMP_token.py   Fri Jun 28 21:36:11 2013 -0500
@@ -158,6 +158,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     # Run each of the ruby memory controllers at a ratio of the frequency of
diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/MOESI_hammer.py
--- a/configs/ruby/MOESI_hammer.py      Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/MOESI_hammer.py      Fri Jun 28 21:36:11 2013 -0500
@@ -133,6 +133,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     #
diff -r 9cd5f91e7a79 -r 52679402e09c configs/ruby/Network_test.py
--- a/configs/ruby/Network_test.py      Thu Jun 27 05:49:51 2013 -0400
+++ b/configs/ruby/Network_test.py      Fri Jun 28 21:36:11 2013 -0500
@@ -105,6 +105,7 @@
 
     phys_mem_size = sum(map(lambda mem: mem.range.size(),
                             system.memories.unproxy(system)))
+    assert(phys_mem_size % options.num_dirs == 0)
     mem_module_size = phys_mem_size / options.num_dirs
 
     # Run each of the ruby memory controllers at a ratio of the frequency of
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to