----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2162/#review4906 -----------------------------------------------------------
Ship it! Ship It! - Andreas Sandberg On Feb. 13, 2014, 3:41 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2162/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 3:41 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10066:b89d41d430d7 > --------------------------- > mem: Fix bug in PhysicalMemory use of mmap and munmap > > This patch fixes a bug in how physical memory used to be mapped and > unmapped. Previously we unmapped and re-mapped if restoring from a > checkpoint. However, we never checked that the new mapping was > actually the same, it was just magically working as the OS seems to > fairly reliably give us the same chunk back. This patch fixes this > issue by relying entirely on the mmap call in the constructor. > > > Diffs > ----- > > src/mem/physical.cc 3b0d0c988ed6 > > Diff: http://reviews.gem5.org/r/2162/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
