> On Feb. 13, 2014, 4:09 p.m., Steve Reinhardt wrote: > > src/mem/cache/cache_impl.hh, line 1445 > > <http://reviews.gem5.org/r/2152/diff/1/?file=39238#file39238line1445> > > > > I don't know if we do this anywhere else, but it might be useful to > > turn AddrRangeList into a full-blown class (not just a typedef) and then > > turn this loop into a contains() method on that class. > > > > I'm fine if you want to save that for another day though.
Good point. I'd suggest to save it for later though. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2152/#review4901 ----------------------------------------------------------- On Jan. 23, 2014, 8:23 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2152/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 8:23 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10022:760e983b77ee > --------------------------- > mem: Filter cache snoops based on address ranges > > This patch adds a filter to the cache to drop snoop requests that are > not for a range covered by the cache. This fixes an issue observed > when multiple caches are placed in parallel, covering different > address ranges. Without this patch, all the caches will forward the > snoop upwards, when only one should do so. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh a362694dda2d > > Diff: http://reviews.gem5.org/r/2152/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
