> On Feb. 25, 2014, 5:20 p.m., Nilay Vaish wrote: > > src/cpu/pred/bi_mode.cc, line 96 > > <http://reviews.gem5.org/r/2174/diff/1/?file=39301#file39301line96> > > > > Can you explain what these constants are? How did you choose them? > > Since you are using these in the update function as well, I suggest that > > you create a separate function for computing the global history index and > > call that function from lookup() and update().
This was very specific to the particular implementation I was modeling. I reverted back to the stock bi-mode's indexing scheme, which should not affect anything. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2174/#review4920 ----------------------------------------------------------- On June 24, 2014, 5:38 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2174/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 5:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10243:18b306b6fce3 > --------------------------- > cpu: implement bi-mode-style branch predictor > > > Diffs > ----- > > configs/common/O3_ARM_v7a.py cb4e86c177672fde6be7a409793c944e36353fc0 > src/cpu/o3/fetch_impl.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/cpu/pred/BranchPredictor.py cb4e86c177672fde6be7a409793c944e36353fc0 > src/cpu/pred/SConscript cb4e86c177672fde6be7a409793c944e36353fc0 > src/cpu/pred/bi_mode.hh PRE-CREATION > src/cpu/pred/bi_mode.cc PRE-CREATION > src/cpu/pred/bpred_unit.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/cpu/pred/bpred_unit.cc cb4e86c177672fde6be7a409793c944e36353fc0 > > Diff: http://reviews.gem5.org/r/2174/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
