As long as Andreas and Nilay are happy, I will go ahead and ship this asap.
Anthony Gutierrez http://web.eecs.umich.edu/~atgutier On Tue, Jun 24, 2014 at 4:43 PM, Ali Saidi <sa...@umich.edu> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2174/ > > Ship it! > > thanks Tony. Looks fine to me > > > - Ali Saidi > > On June 24th, 2014, 6:24 p.m. UTC, Anthony Gutierrez wrote: > Review request for Default. > By Anthony Gutierrez. > > *Updated June 24, 2014, 6:24 p.m.* > *Repository: * gem5 > Description > > Changeset 10243:21d1d03c782e > --------------------------- > cpu: implement bi-mode-style branch predictor > > Diffs > > - src/cpu/o3/fetch_impl.hh (cb4e86c177672fde6be7a409793c944e36353fc0) > - src/cpu/pred/BranchPredictor.py > (cb4e86c177672fde6be7a409793c944e36353fc0) > - src/cpu/pred/SConscript (cb4e86c177672fde6be7a409793c944e36353fc0) > - src/cpu/pred/bi_mode.hh (PRE-CREATION) > - src/cpu/pred/bi_mode.cc (PRE-CREATION) > - src/cpu/pred/bpred_unit.hh (cb4e86c177672fde6be7a409793c944e36353fc0) > - src/cpu/pred/bpred_unit.cc (cb4e86c177672fde6be7a409793c944e36353fc0) > > View Diff <http://reviews.gem5.org/r/2174/diff/> > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev