----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2468/#review5432 -----------------------------------------------------------
src/cpu/o3/lsq_impl.hh <http://reviews.gem5.org/r/2468/#comment4912> I'm not sure which version of gem5 you're using, but in the latest dev repository it looks like this if block is completely gone. I'm not sure if that is because the check has been moved elsewhere or otherwise. - Ali Saidi On Oct. 26, 2014, 5:16 p.m., Alberto Javier Naranjo Carmona wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2468/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2014, 5:16 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch solves some bugs that occured when using the option > --repeat-switch, in particular when switching from O3 to timing model > (deadlocks while draining and assert(!memReq) in drainSanityCheck()). See the > following thread for more info > http://www.mail-archive.com/gem5-users%40gem5.org/msg10631.html > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh PRE-CREATION > src/cpu/o3/lsq_impl.hh PRE-CREATION > src/cpu/o3/lsq_unit.hh PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2468/diff/ > > > Testing > ------- > > All long regression tests passed. tsunami-switcheroo-full passed. > > > Thanks, > > Alberto Javier Naranjo Carmona > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
