----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2468/#review5448 -----------------------------------------------------------
Ship it! the o3 change seems fine. . someone more familiar with ruby would need to comment on the other one. - Ali Saidi On Nov. 7, 2014, 9:35 p.m., Alberto Javier Naranjo Carmona wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2468/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 9:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch solves some bugs that occured when using the option > --repeat-switch, in particular when switching from O3 to timing model > (deadlocks while draining and assert(!memReq) in drainSanityCheck()). See the > following thread for more info > http://www.mail-archive.com/gem5-users%40gem5.org/msg10631.html > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh PRE-CREATION > src/mem/ruby/structures/RubyMemoryControl.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2468/diff/ > > > Testing > ------- > > All long regression tests passed. tsunami-switcheroo-full passed. > > > Thanks, > > Alberto Javier Naranjo Carmona > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
