----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10540:0d0fabda59bd --------------------------- mem: Remove null-check bypassing in Packet::getPtr This patch removes the parameter that enables bypassing the null check in the Packet::getPtr method. A number of call sites assume the value to be non-null. The one odd case is the RubyTester, which issues zero-sized prefetches(!), and despite being reads they had no valid data pointer. This is now fixed, but the size oddity remains (unless anyone object or has any good suggestions). Finally, in the Ruby Sequencer, appropriate checks are made for flush packets as they have no valid data pointer. Diffs ----- src/cpu/testers/rubytest/Check.cc 1a9e235cab09 src/mem/packet.hh 1a9e235cab09 src/mem/ruby/slicc_interface/RubyRequest.cc 1a9e235cab09 src/mem/ruby/slicc_interface/RubySlicc_Util.hh 1a9e235cab09 src/mem/ruby/system/DMASequencer.cc 1a9e235cab09 src/mem/ruby/system/Sequencer.cc 1a9e235cab09 Diff: http://reviews.gem5.org/r/2490/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
