> On Nov. 29, 2014, 8:04 p.m., Steve Reinhardt wrote: > > The changes to getPtr() look good to me. > > > > On the broader topic of zero-sized prefetches, I'm a little confused... I > > can see a CPU or CPU-like object (i.e., a tester) generate a zero-size > > prefetch as a "touch" operation, but then it seems like the cache would > > need to generate a cache-line-sized prefetch read since it's going to need > > to receive data. At least that's how it would work in the classic memory > > system, which makes sense to me :). I don't understand why Ruby should be > > different.
I leave the prefetch for some Ruby ninja to change. I agree with you that it should probably be cache-line sized. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5568 ----------------------------------------------------------- On Nov. 24, 2014, 12:18 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2490/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 12:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10563:3a541e8c1ff1 > --------------------------- > mem: Remove null-check bypassing in Packet::getPtr > > This patch removes the parameter that enables bypassing the null check > in the Packet::getPtr method. A number of call sites assume the value > to be non-null. > > The one odd case is the RubyTester, which issues zero-sized > prefetches(!), and despite being reads they had no valid data > pointer. This is now fixed, but the size oddity remains (unless anyone > object or has any good suggestions). > > Finally, in the Ruby Sequencer, appropriate checks are made for flush > packets as they have no valid data pointer. > > > Diffs > ----- > > src/cpu/testers/rubytest/Check.cc 426665ec11a9 > src/mem/packet.hh 426665ec11a9 > src/mem/ruby/slicc_interface/RubyRequest.cc 426665ec11a9 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 426665ec11a9 > src/mem/ruby/system/DMASequencer.cc 426665ec11a9 > src/mem/ruby/system/Sequencer.cc 426665ec11a9 > > Diff: http://reviews.gem5.org/r/2490/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
