----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2518/#review5695 -----------------------------------------------------------
src/dev/x86/i8042.hh <http://reviews.gem5.org/r/2518/#comment5077> I know it is not changed, but could you elaborate on the unit? src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2518/#comment5075> const? src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2518/#comment5076> const? src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2518/#comment5078> , _space_ src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2518/#comment5079> For the body of this, could you elaborate on why it looks the way it does? At the moment it is very thin on comments src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2518/#comment5080> setMouseAt? Looks good, some minor things - Andreas Hansson On Nov. 23, 2014, 1:50 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2518/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 1:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10555:a13dc3596e45 > --------------------------- > x86: i8042: Add VNC mouse support, and flesh out the mouse model. > > This change fleshes out the mouse model so that it can send mouse data to the > simulated system somewhat realistically, and hooks it into the VNC server as > the mouse input device. > > > Diffs > ----- > > src/dev/x86/I8042.py f9fb64a72259a2514080151b5250a04c575d443a > src/dev/x86/i8042.hh f9fb64a72259a2514080151b5250a04c575d443a > src/dev/x86/i8042.cc f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2518/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
