> On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.hh, line 118 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42731#file42731line118> > > > > I know it is not changed, but could you elaborate on the unit?
I'll have to look at it again to figure out what the unit is, but yeah, that seems reasonable. > On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 122 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42732#file42732line122> > > > > const? No, because writeData sets state. > On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 135 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42732#file42732line135> > > > > const? Nope. statusReg is modified. > On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 248 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42732#file42732line248> > > > > , _space_ Yep. I'll fix that. > On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 250 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42732#file42732line250> > > > > For the body of this, could you elaborate on why it looks the way it > > does? At the moment it is very thin on comments Yes. > On Dec. 17, 2014, 1:53 p.m., Andreas Hansson wrote: > > src/dev/x86/i8042.cc, line 410 > > <http://reviews.gem5.org/r/2518/diff/2/?file=42732#file42732line410> > > > > setMouseAt? I believe that's part of the VNC interface which is defined outside this device. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2518/#review5695 ----------------------------------------------------------- On Nov. 23, 2014, 1:50 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2518/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 1:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10555:a13dc3596e45 > --------------------------- > x86: i8042: Add VNC mouse support, and flesh out the mouse model. > > This change fleshes out the mouse model so that it can send mouse data to the > simulated system somewhat realistically, and hooks it into the VNC server as > the mouse input device. > > > Diffs > ----- > > src/dev/x86/I8042.py f9fb64a72259a2514080151b5250a04c575d443a > src/dev/x86/i8042.hh f9fb64a72259a2514080151b5250a04c575d443a > src/dev/x86/i8042.cc f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2518/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
