if you go here: http://reviews.gem5.org/r/2557/
there is a 'Download Diff' button on the first active line of the review (about 3 down from the 'Review board 1.7.9') You download it, and then apply it using the method I PMed you. On Thu, Jan 15, 2015 at 4:36 PM, Amit Gaikwad <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2557/ > > On December 10th, 2014, 10:30 p.m. UTC, *mike upton* wrote: > > There is some issue with AMD platforms. A test that used to run in 30 sec is > not finishing. > > > On December 10th, 2014, 10:32 p.m. UTC, *mike upton* wrote: > > hello world passes. SPEC apps hang. > > On December 10th, 2014, 10:41 p.m. UTC, *Gabe Black* wrote: > > Can you identify where it's getting stuck? It could be there's something > wrong with how exception handling is set up, and it gets stuck faulting over > and over when a page fault happens, for instance. You could have the KVM CPU > print what the IP is each time it regains control and see if they cluster > somewhere interesting. > > On December 11th, 2014, 8:12 a.m. UTC, *Gabe Black* wrote: > > Any luck? Unfortunately the time I have to work on gem5 is pretty limited, so > I probably won't be able to dig into this for a while. > > On January 5th, 2015, 11:12 p.m. UTC, *mike upton* wrote: > > on the intel platform, with the test input set, all of cpu2006 integer tests > pass, except for astar. > astar dies with a panic and page fault. > [m5PageFault:build/X86/arch/x86/pseudo_inst.cc, line 85] > > on the amd platform, all of the tests I tried fail to complete. > time continues to advance, but instructions are not completing. > > I am not sure what to do, I need the Intel platform code, but we should not > break the AMD side. > > Are there any AMD folks I can work with to figure out how to get both sides > working? > > > On January 6th, 2015, 6:39 p.m. UTC, *Alexandru Dutu* wrote: > > Sorry about the late reply, I remember replying on a different mailing list > thread about this. I have tried this patch on my AMD system with some short > running applications and things worked fine. So, I will run cpu2006 and see > if there are any issues. > > On January 11th, 2015, 8:48 a.m. UTC, *Alexandru Dutu* wrote: > > When running SPEC CPU2006 with latest gem5 on a 6 core Bulldozer, Ubuntu > 14.04, linux 3.13.0-34, most of them call exit_group syscall except gromacs > which fails because of unimplemented clock_gettime syscall. This means they > ran until completion, however I have not yet checked if the output is > actually correct. > > However, after applying this patch things break and there are unexpected > exits in the middle of the execution. Looking more into it and coming up with > more details. > > On January 15th, 2015, 5:27 p.m. UTC, *Amit Gaikwad* wrote: > > I am new to gem5. Can someone please let me know where can I find the > wip.patch and also what will be command for patching gem5 ? > > On January 15th, 2015, 10:55 p.m. UTC, *mike upton* wrote: > > I am also having trouble running this patch on a different intel x86 system. > It looks like there are both segmentation changes, and KVM changes merged > together. > > Can we split it into 2 separate patches? > > I think some of the style cleanup in the segmentation stuff changed the > behavior. > > If no one else does it, I will attempt a separate minimal patch that just > fixes the KVM stuff. > > @ Mike Upton, > > I am not even able to find the patch and I am actively looking for it. > Did you manually change the below 6 files ? Can you please let me know ? > > src/arch/x86/process.cc: 8 changes > src/arch/x86/system.hh: 1 change > src/arch/x86/system.cc: 3 changes > src/arch/x86/utility.hh: 2 changes > src/arch/x86/utility.cc: 1 change > src/cpu/kvm/x86_cpu.cc: 2 changes > > The changes listed on this link : http://reviews.gem5.org/r/2557/diff/1-2/ > > > > - Amit > > On December 10th, 2014, 10:11 a.m. UTC, Gabe Black wrote: > Review request for Default. > By Gabe Black. > > *Updated Dec. 10, 2014, 10:11 a.m.* > *Repository: * gem5 > Description > > Changeset 10606:aa3eb7453246 > --------------------------- > x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs. > > There were a number of problems with how things were initialized which prevent > VMX from running the simulation as a guest. > > Diffs > > - src/arch/x86/process.cc (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/arch/x86/regs/misc.hh (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/arch/x86/system.hh (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/arch/x86/system.cc (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/arch/x86/utility.hh (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/arch/x86/utility.cc (8fc6e7a835d1d313e139c9095251105f904ac1b4) > - src/cpu/kvm/x86_cpu.cc (8fc6e7a835d1d313e139c9095251105f904ac1b4) > > View Diff <http://reviews.gem5.org/r/2557/diff/> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
