> On Feb. 6, 2015, 12:18 a.m., Andreas Hansson wrote: > > It think there are more (and bigger issues) at play here. I'd suggest to > > try this out with: http://reviews.gem5.org/r/2626/ > > > > If you run it with "-p", prefetches enabled, it doesn't take many seconds > > before it hits an assert. We're working on fixing it, and #2626 is a step > > on the way.
Hi Andreas, Are you saying that you will be coming out with a patch soon that will subsume this one? I don't doubt that there are more bugs to be fixed, but this patch most definitely fixes one of them (the one that George was running into, and the only one he's run into so far). I'm fine with holding off if a more comprehensive fix is imminent, but on the other hand I don't want to not fix one bug just because the patch fails to fix all the bugs... - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2636/#review5849 ----------------------------------------------------------- On Feb. 5, 2015, 4:38 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2636/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 4:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10683:3147f3a868f7 > --------------------------- > mem: fix prefetcher bug regarding write buffer hits > > Prefetches are supposed to be squashed if the block is already > present in a higher-level cache. We squash appropriately if > the block is in a higher-level cache or MSHR, but did not > properly handle the case where the block is in the write buffer. > > Thanks to George Michelogiannakis <[email protected]> for > help in tracking down and testing this fix. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 3d17366c0423a59478ae63d40c8feeea34df218a > > Diff: http://reviews.gem5.org/r/2636/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
