On Wed, 4 Mar 2015, Andreas Hansson wrote:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2680/#review5937 ----------------------------------------------------------- Should this perhaps be a probe rather?
OK, I just read the commit message from the changeset 10023 91faf6649de0. I am going to argue against separating statistics gathering from the so called functional code. One of the ways I use to learn gem5 (or have used) is observing how the statistics are being collected. Moving statistics collection to a separate file, makes that collection code less visible, which is as important as the functional code itself. This approach was being used in ruby originally. And I changed it (changeset 67d9da312ef0) so that a person reading the code knows what statistic is being updated when.
-- Nilay _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
