----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review6844 -----------------------------------------------------------
src/mem/serial_link.cc (line 155) <http://reviews.gem5.org/r/2986/#comment5909> Cycles as the type Should you use divCeil here? Should there not be overheads in addition to the packet size? 16 bytes (make it a parameter?) src/mem/serial_link.cc (line 160) <http://reviews.gem5.org/r/2986/#comment5910> no need to do this, call schedTimingResp(pkt, t, true). Why would changing the order be a problem? src/mem/serial_link.cc (line 216) <http://reviews.gem5.org/r/2986/#comment5911> Same as the other one in terms of units, divCeil, and flit overhead. We should definitely add the pkt->headerDelay before zeroing it. Should we not also add pkt->payloadDelay? Can we start serialising before the "link controller" has the entire packet? - Andreas Hansson On July 23, 2015, 8:16 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 8:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10928:6b8b6122d2d3 > --------------------------- > Simple HMC Model > > > Diffs > ----- > > configs/common/HMC.py PRE-CREATION > configs/common/MemConfig.py 9689ead7b479 > configs/example/fs.py 9689ead7b479 > configs/example/hmctest.py PRE-CREATION > src/mem/DRAMCtrl.py 9689ead7b479 > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 9689ead7b479 > src/mem/SerialLink.py PRE-CREATION > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/serial_link.hh PRE-CREATION > src/mem/serial_link.cc PRE-CREATION > src/mem/xbar.hh 9689ead7b479 > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
