> On Oct. 14, 2015, 2:02 a.m., Nilay Vaish wrote: > > Format this patch again. Read the following page: > > http://gem5.org/Submitting_Contributions
There are several lines are more than 80 characters. Also make sure that the identation is correct. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review7370 ----------------------------------------------------------- On Oct. 14, 2015, 9:05 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 9:05 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11173:4081d8bd56f6 > --------------------------- > Simple HMC Model > > > Diffs > ----- > > configs/common/HMC.py PRE-CREATION > configs/common/MemConfig.py 9261e98e4501 > configs/example/fs.py 9261e98e4501 > configs/example/hmctest.py PRE-CREATION > src/mem/DRAMCtrl.py 9261e98e4501 > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 9261e98e4501 > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/xbar.hh 9261e98e4501 > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
