----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3003/#review6902 -----------------------------------------------------------
Hi Andreas, I was going to look at addressing this today for AMD. I'm not extremely familiar with the organization of the request flags, packet commands, packet attributes, and packet flags. That said, I was under the impression that the request is supposed to capture information that exist at the instruction level. To me, acquire and release are at the instruction level (not a spurious command between two memory controllers like flush command). Also, the 32 bits that we have to work with in the request seems rather small. Especially, when you consider that it needs to capture all of the possible attributes for a memory request across all of the different ISAs... How would armv8 ldra and strl instructions convey to the cache hierarchy acquire/release attributes from the instruction (if it were necessary). - Marc Orr On Aug. 5, 2015, 8:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3003/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 8:51 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11001:5b78d01bf635 > --------------------------- > mem: Remove extraneous acquire/release flags and attributes > > This patch removes the extraneous flags and attributes from the > request and packet, and simply leaves the new commands. The change > introduced when adding acquire/release breaks all compatibility with > existing traces, and there is really no need for any new flags and > attributes. The commands should be sufficient. > > This patch fixes packet tracing (urgent), and also removes the > unnecessary complexity. > > > Diffs > ----- > > src/mem/packet.hh cd22d66592bf > src/mem/packet.cc cd22d66592bf > src/mem/request.hh cd22d66592bf > > Diff: http://reviews.gem5.org/r/3003/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
