> On Aug. 5, 2015, 9:26 p.m., Marc Orr wrote: > > Hey Andreas, > > > > Go ahead and ship this. But I would appreciate your thoughts on my comment. > > I will move that over to an email thread on gem5-dev. Simply put, we need > > to get this information down to the cache controllers, and I would like to > > do it in a way that everyone is happy with and can even leverage in their > > own work. > > > > Thanks, > > Marc
I responded to the mail. I think we can work this out without adding request flags and packet attributes. I'll go ahead and push this for now, and then we can converge on the mailing list. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3003/#review6903 ----------------------------------------------------------- On Aug. 5, 2015, 8:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3003/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 8:51 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11001:5b78d01bf635 > --------------------------- > mem: Remove extraneous acquire/release flags and attributes > > This patch removes the extraneous flags and attributes from the > request and packet, and simply leaves the new commands. The change > introduced when adding acquire/release breaks all compatibility with > existing traces, and there is really no need for any new flags and > attributes. The commands should be sufficient. > > This patch fixes packet tracing (urgent), and also removes the > unnecessary complexity. > > > Diffs > ----- > > src/mem/packet.hh cd22d66592bf > src/mem/packet.cc cd22d66592bf > src/mem/request.hh cd22d66592bf > > Diff: http://reviews.gem5.org/r/3003/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
