> On Aug. 14, 2015, 9:04 p.m., Joel Hestness wrote: > > I'd rather not remove this stat. I didn't know it was incorrect, but even > > so, it's been really useful for tracking nuanced buffering issues/bugs. Can > > we just leave it for now?
OK. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2990/#review6959 ----------------------------------------------------------- On July 24, 2015, 4:46 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2990/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 4:46 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10956:dae80ffaea97 > --------------------------- > ruby: drop the histogram for tracking number of outstanding requests > > The histogram is not maintained properly since in a cycle multiple requests > can come in > > > Diffs > ----- > > src/mem/ruby/profiler/Profiler.hh 9689ead7b479 > src/mem/ruby/profiler/Profiler.cc 9689ead7b479 > src/mem/ruby/system/Sequencer.hh 9689ead7b479 > src/mem/ruby/system/Sequencer.cc 9689ead7b479 > > Diff: http://reviews.gem5.org/r/2990/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
