----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3153/#review7367 -----------------------------------------------------------
Ship it! src/mem/packet_queue.cc (lines 138 - 141) <http://reviews.gem5.org/r/3153/#comment6223> These lines can be dropped. I'll leave the decision to you. - Nilay Vaish On Oct. 13, 2015, 11:18 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3153/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 11:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11172:4c06f99026cd > --------------------------- > mem: Order packet queue only on matching addresses > > Instead of conservatively enforcing order for all packets, which may > negatively impact the simulated-system performance, this patch updates > the packet queue such that it only applies the restriction if there > are already packets with the same address in the queue. > > The basic need for the order enforcement is due to coherency > interactions where requests/responses to the same cache line must not > over-take each other. We rely on the fact that any packet that needs > order enforcement will have a block-aligned address. Thus, there is no > need for the queue to know about the cacheline size. > > > Diffs > ----- > > src/mem/packet_queue.hh 44b5c183c3cd > src/mem/packet_queue.cc 44b5c183c3cd > > Diff: http://reviews.gem5.org/r/3153/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
