-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3153/
-----------------------------------------------------------

(Updated Oct. 19, 2015, 3:08 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
-------

Changeset 11176:3a4d9e14ae5d
---------------------------
mem: Order packet queue only on matching addresses

Instead of conservatively enforcing order for all packets, which may
negatively impact the simulated-system performance, this patch updates
the packet queue such that it only applies the restriction if there
are already packets with the same address in the queue.

The basic need for the order enforcement is due to coherency
interactions where requests/responses to the same cache line must not
over-take each other. We rely on the fact that any packet that needs
order enforcement will have a block-aligned address. Thus, there is no
need for the queue to know about the cacheline size.


Diffs (updated)
-----

  src/mem/packet_queue.hh 3a4d1b5cd05c 
  src/mem/packet_queue.cc 3a4d1b5cd05c 

Diff: http://reviews.gem5.org/r/3153/diff/


Testing
-------


Thanks,

Andreas Hansson

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to