----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3425/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11427:372b57df72d3 --------------------------- ruby: write mask method changes w/ manual subsequent initializations The write mask method was depending on the statically declared block size to initialize it's internal bitmask. We change the default behavior to initialize an empty bitmask (due to the lack of constructors with SLICC's new); subsequently we immediately initialize the write mask with the size for objects that need the write mask. Diffs ----- src/mem/protocol/MOESI_AMD_Base-RegionDir.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-dir.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-probeFilter.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/RubySlicc_Exports.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/common/WriteMask.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-Region-CorePair.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-Region-dir.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-RegionBuffer.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER-TCP.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER_Region-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-CorePair.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/MOESI_AMD_Base-L3cache.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-TCCdir.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-TCP.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER-SQC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_VIPER-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-SQC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/protocol/GPU_RfO-TCC.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3425/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
