> On April 6, 2016, 7:25 p.m., Brandon Potter wrote: > > src/mem/slicc/ast/NewExprASTParams.py, line 46 > > <http://reviews.gem5.org/r/3427/diff/1/?file=54526#file54526line46> > > > > I will highlight this myself since I'd like to fix this, but I don't > > know what a good solution would look like. > > > > The issue is that I need to supply a parameter list here with the m_ > > attached with the constructor. (The block_size (and any other parameters) > > will be using the m_ notation.) > > This is a hacky way to achieve that and I don't think that the other > > grammer statements do this for member types. > > > > Also, I do not check to verify that this param has been declared witin > > slicc. I am open to solutions on how to fix that too.
Let's talk off-line about how to improve this patch. I do not think adding a new AST file is necessary. I believe we can make updates to the existing NewExprAST.py file instead. As far as verifying that the param has been declared, look at MemberExprAST.py as an example. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3427/#review8149 ----------------------------------------------------------- On April 4, 2016, 11:42 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3427/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:42 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11429:5990fc6e2e53 > --------------------------- > ruby: add new rule to grammer to handle new'd objects with parameters > > > Diffs > ----- > > src/mem/slicc/parser.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/slicc/ast/NewExprASTParams.py PRE-CREATION > src/mem/slicc/ast/__init__.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3427/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
