----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3555/#review8504 -----------------------------------------------------------
Some minor style issues which you can see on the reviewboard need to be fixed, otherwise looks good. configs/topologies/Mesh_westfirst.py (lines 125 - 128) <http://reviews.gem5.org/r/3555/#comment7382> Minor nitpick, but this seems like east-first to me, since the links with weight 1 send from west to east. But this all depends how you look at the map :) - Matthew Poremba On July 13, 2016, 7:03 a.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3555/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 7:03 a.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > topology: make internal links unidirectional. > This patch makes the internal links within the network topology > unidirectional, thus allowing any deadlock-free routing algorithms to > be specified from the topology itself using weights. > This patch also renames Mesh.py and MeshDirCorners.py to > Mesh_XY.py and MeshDirCorners_XY.py (Mesh with XY routing). > It also adds a Mesh_westfirst.py and CrossbarGarnet.py topologies. > > > Diffs > ----- > > configs/topologies/Cluster.py cdb94f2332a6 > configs/topologies/Crossbar.py cdb94f2332a6 > configs/topologies/CrossbarGarnet.py PRE-CREATION > configs/topologies/Mesh.py cdb94f2332a6 > configs/topologies/MeshDirCorners.py cdb94f2332a6 > configs/topologies/MeshDirCorners_XY.py PRE-CREATION > configs/topologies/Mesh_XY.py PRE-CREATION > configs/topologies/Mesh_westfirst.py PRE-CREATION > configs/topologies/Pt2Pt.py cdb94f2332a6 > configs/topologies/Torus.py cdb94f2332a6 > src/mem/ruby/network/BasicLink.hh cdb94f2332a6 > src/mem/ruby/network/BasicLink.cc cdb94f2332a6 > src/mem/ruby/network/BasicLink.py cdb94f2332a6 > src/mem/ruby/network/Network.hh cdb94f2332a6 > src/mem/ruby/network/Topology.hh cdb94f2332a6 > src/mem/ruby/network/Topology.cc cdb94f2332a6 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh cdb94f2332a6 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc cdb94f2332a6 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh cdb94f2332a6 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc cdb94f2332a6 > src/mem/ruby/network/simple/SimpleNetwork.hh cdb94f2332a6 > src/mem/ruby/network/simple/SimpleNetwork.cc cdb94f2332a6 > src/mem/ruby/network/simple/SimpleNetwork.py cdb94f2332a6 > > Diff: http://reviews.gem5.org/r/3555/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
