> On July 22, 2016, 11 p.m., Matthew Poremba wrote: > > configs/topologies/Mesh_westfirst.py, lines 125-128 > > <http://reviews.gem5.org/r/3555/diff/1/?file=57035#file57035line125> > > > > Minor nitpick, but this seems like east-first to me, since the links > > with weight 1 send from west to east. But this all depends how you look at > > the map :)
These are actually links going from the west output port of the source to the east input port of the dest. So it is West-first. You always try to use the west output port as that has the lowest weight. I have made this clearer in the new patch by renaming "west_id" to "west_out" and "east_id" to "east_in". - Tushar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3555/#review8504 ----------------------------------------------------------- On Aug. 24, 2016, 3:22 p.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3555/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 3:22 p.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > config: make internal links in network topology unidirectional. > This patch makes the internal links within the network topology > unidirectional, thus allowing any deadlock-free routing algorithms to > be specified from the topology itself using weights. > This patch also renames Mesh.py and MeshDirCorners.py to > Mesh_XY.py and MeshDirCorners_XY.py (Mesh with XY routing). > It also adds a Mesh_westfirst.py and CrossbarGarnet.py topologies. > > > Diffs > ----- > > src/mem/ruby/network/simple/SimpleNetwork.cc d726d0cea027 > src/mem/ruby/network/simple/SimpleNetwork.py d726d0cea027 > src/mem/ruby/network/BasicLink.py d726d0cea027 > src/mem/ruby/network/Network.hh d726d0cea027 > src/mem/ruby/network/Topology.hh d726d0cea027 > src/mem/ruby/network/Topology.cc d726d0cea027 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh d726d0cea027 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc d726d0cea027 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh d726d0cea027 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc d726d0cea027 > src/mem/ruby/network/simple/SimpleNetwork.hh d726d0cea027 > configs/topologies/Cluster.py d726d0cea027 > configs/topologies/Crossbar.py d726d0cea027 > configs/topologies/CrossbarGarnet.py PRE-CREATION > configs/topologies/Mesh.py d726d0cea027 > configs/topologies/MeshDirCorners.py d726d0cea027 > configs/topologies/MeshDirCorners_XY.py PRE-CREATION > configs/topologies/Mesh_XY.py PRE-CREATION > configs/topologies/Mesh_westfirst.py PRE-CREATION > configs/topologies/Pt2Pt.py d726d0cea027 > configs/topologies/Torus.py d726d0cea027 > src/mem/ruby/network/BasicLink.hh d726d0cea027 > src/mem/ruby/network/BasicLink.cc d726d0cea027 > > Diff: http://reviews.gem5.org/r/3555/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
