> On July 27, 2016, 4:52 p.m., Andreas Hansson wrote: > >
To be clear: Please go ahead with the patch as is. I merely wanted to hightlight that there is room for further patches and improvements. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8552 ----------------------------------------------------------- On July 28, 2016, 10:31 a.m., Sophiane SENNI wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3502/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 10:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11536:1a3a96d435ed > --------------------------- > mem: Split the hit_latency into tag_latency and data_latency > > If the cache access mode is parallel, i.e. "sequential_access" parameter > is set to "False", tags and data are accessed in parallel. Therefore, > the hit_latency is the maximum latency between tag_latency and > data_latency. On the other hand, if the cache access mode is > sequential, i.e. "sequential_access" parameter is set to "True", > tags and data are accessed sequentially. Therefore, the hit_latency > is the sum of tag_latency plus data_latency. > > > Diffs > ----- > > configs/common/Caches.py 4aac82f109517217e6bfb3812689280e7a8fa842 > configs/common/O3_ARM_v7a.py 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/Cache.py 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/base.hh 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/base.cc 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/tags/Tags.py 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/tags/base.hh 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/tags/base.cc 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/tags/base_set_assoc.hh > 4aac82f109517217e6bfb3812689280e7a8fa842 > src/mem/cache/tags/fa_lru.cc 4aac82f109517217e6bfb3812689280e7a8fa842 > > Diff: http://reviews.gem5.org/r/3502/diff/ > > > Testing > ------- > > Tested using --Debug-flags=Cache > > > Thanks, > > Sophiane SENNI > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
