> On Sept. 6, 2016, 9:34 a.m., Andreas Sandberg wrote: > > src/dev/arm/pl011.cc, line 232 > > <http://reviews.gem5.org/r/3623/diff/1/?file=57828#file57828line232> > > > > Do you actually need the check against maskInt() here? The necessary > > checks should already be inplace in dataAvailable()/raiseInterrupts().
I can't see the conditional check in either; well setInterrupts() does have a check but to my understanding is not exactly doing this based on what's passed in for this code path. It's just RX and not TX. I think the 8250 UART code does the same, so keeping it "similar" seems a good idea ;-) - Bjoern A. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8709 ----------------------------------------------------------- On Sept. 5, 2016, 10:22 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3623/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2016, 10:22 p.m.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > Improve PL011 console interactivity > > > Diffs > ----- > > src/dev/arm/pl011.cc d726d0cea027 > > Diff: http://reviews.gem5.org/r/3623/diff/ > > > Testing > ------- > > We are operating in "register mode" (not FIFO) which means if we clear an > interrupt and have more data available, we need to re-raise the interrupt > again. Add two more cases where this is needed. > > With this the interactivity on FreeBSD went to usable. Before this after a > certain event, it could take up to 15(?) additional charatcers to get > previously pasted command lines echoed and executed. > > I have a possible report about similar behaviour from people at ARM on Linux > (uncofirmed) and I am putting the patch up so they can test. > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
