> On Sept. 6, 2016, 10:52 a.m., Andreas Sandberg wrote: > > src/dev/arm/pl011.cc, line 232 > > <http://reviews.gem5.org/r/3623/diff/1/?file=57828#file57828line232> > > > > I'm not sure I understand exactly what this condition is supposed to > > test. The check currently tests if there is an unmasked RX interrupt > > pending before raising a new RX interrupt. I suspect the intention might be > > to check if the RX interrupt is enabled (maskInt() is a bit of a misnomer). > > > > You shouldn't need to worry about the mask (or whether the interrupt is > > pending) here since setInterrupts won't poke the GIC unless there is a new > > interrupt pending (raising a pending interrupt is effectively a no-op).
Doh! Sure. I see what you mean. It should have been imsc & UART_RXINTR which is pointless as that's indeed what is abstracted through dataAvailable() in the pl011 code. I'll drop the condition and re-check. - Bjoern A. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8711 ----------------------------------------------------------- On Sept. 5, 2016, 10:22 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3623/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2016, 10:22 p.m.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > Improve PL011 console interactivity > > > Diffs > ----- > > src/dev/arm/pl011.cc d726d0cea027 > > Diff: http://reviews.gem5.org/r/3623/diff/ > > > Testing > ------- > > We are operating in "register mode" (not FIFO) which means if we clear an > interrupt and have more data available, we need to re-raise the interrupt > again. Add two more cases where this is needed. > > With this the interactivity on FreeBSD went to usable. Before this after a > certain event, it could take up to 15(?) additional charatcers to get > previously pasted command lines echoed and executed. > > I have a possible report about similar behaviour from people at ARM on Linux > (uncofirmed) and I am putting the patch up so they can test. > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
