----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9036 -----------------------------------------------------------
src/sim/futex_map.hh (line 5) <http://reviews.gem5.org/r/3702/#comment7775> This is not the license we should be using. See the gpu-compute code for our license. src/sim/futex_map.hh (line 66) <http://reviews.gem5.org/r/3702/#comment7776> This comment needs more detail. src/sim/futex_map.hh (line 91) <http://reviews.gem5.org/r/3702/#comment7777> Newline after the return type. src/sim/se_signal.cc (line 2) <http://reviews.gem5.org/r/3702/#comment7778> Should this not be 2014, 2016? - Tony Gutierrez On Nov. 7, 2016, 2:20 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3702/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 2:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11710:0f51ecfa24aa > --------------------------- > syscall_emul: [PATCH 21/22] rewrite code related to system call exits > > The changeset refactors exit, exit_group, and futex related exit > functionality. > > > Diffs > ----- > > src/sim/futex_map.hh PRE-CREATION > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/se_signal.hh PRE-CREATION > src/sim/se_signal.cc PRE-CREATION > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3702/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
