----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/#review9052 -----------------------------------------------------------
src/sim/futex_map.hh (line 65) <http://reviews.gem5.org/r/3702/#comment7789> I'm not sure if this is needed. src/sim/futex_map.hh (line 81) <http://reviews.gem5.org/r/3702/#comment7791> Why not something simple, like: return std::hash(addr) ^ (std::hash(tgid) << 1) src/sim/system.hh (line 73) <http://reviews.gem5.org/r/3702/#comment7793> spurious whitespace change - Michael LeBeane On Nov. 14, 2016, 6:49 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3702/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 6:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11728:be8e9fbd0bec > --------------------------- > syscall_emul: [PATCH 21/22] rewrite code related to system call exits > > The changeset refactors exit, exit_group, and futex related exit > functionality. > > > Diffs > ----- > > src/sim/se_signal.hh PRE-CREATION > src/sim/se_signal.cc PRE-CREATION > src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/futex_map.hh PRE-CREATION > src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3702/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
