----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9160 -----------------------------------------------------------
Thanks for the updates. I'm still not clear on the histBufferSize (as detailed below). src/cpu/pred/BranchPredictor.py (line 100) <http://reviews.gem5.org/r/3743/#comment7878> Comment is now wrong. Also, does it make more sense to call this histBufferEntries (or histBufferBits) and make the default 2**21? (or would it be 2**21*8? <-- this is the confusion.) I think it would be more clear to use bits or entries, personally. But if the branch predictor papers usually talk about the history buffer in terms of bytes instead of bits, I guess the current version makes more sense. Thanks - Jason Lowe-Power On Nov. 23, 2016, 2:52 p.m., Arthur Perais wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3743/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 2:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:1d085f66c4ca > --------------------------- > > cpu: implement an L-TAGE branch predictor > > This patch implements an L-TAGE predictor, based on André Seznec's code > available from > CBP-2 > (http://hpca23.cse.tamu.edu/taco/camino/cbp2/cbp-src/realistic-seznec.h). The > patch also changes the default branch predictor of o3 from the tournament > predictor > to L-TAGE. > > This patch requires patch #3727 (http://reviews.gem5.org/r/3727/) to compile. > > > Diffs > ----- > > src/cpu/pred/BranchPredictor.py 1d085f66c4ca > src/cpu/pred/SConscript 1d085f66c4ca > src/cpu/pred/ltage.hh PRE-CREATION > src/cpu/pred/ltage.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3743/diff/ > > > Testing > ------- > > > Thanks, > > Arthur Perais > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
