----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9457 -----------------------------------------------------------
Thanks for getting this in shape. Some minor things worth considering. CONTRIBUTING.md (line 7) <http://reviews.gem5.org/r/3814/#comment7979> This is quite defensive and negative at the moment. Could we not make 1 and 2: * Share your work with others, so that they can benefit from new functionality. * Support the scientific principle by enabling others to evaluate your suggestions without having to guess what you did. CONTRIBUTING.md (line 10) <http://reviews.gem5.org/r/3814/#comment7978> I would think we should drop the s at the end. CONTRIBUTING.md (line 69) <http://reviews.gem5.org/r/3814/#comment7980> Is there a step where tests/regressions are added and/or updated, or is that perhaps too much detail for this doc? - Andreas Hansson On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3814/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 5:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 11849:b5f456096b51 "misc: Add a CONTRIBUTING document > > This document details how to contribute to gem5 based on our new > contribution flow with git and gerrit. > > Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" > > > Diffs > ----- > > CONTRIBUTING.md PRE-CREATION > > Diff: http://reviews.gem5.org/r/3814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
