> On Feb. 23, 2017, 11:20 a.m., Andreas Hansson wrote: > > CONTRIBUTING.md, line 69 > > <http://reviews.gem5.org/r/3814/diff/2/?file=66037#file66037line69> > > > > Is there a step where tests/regressions are added and/or updated, or is > > that perhaps too much detail for this doc?
We probably shouldn't include that in the general contribution guide since users in general can't run the regressions (binary restrictions etc.). The code review system will integrate with a hosted Jenkins instance to automatically test that code is functionally correct, but there is little we can do automatically for stat diffs. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9457 ----------------------------------------------------------- On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3814/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 5:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 11849:b5f456096b51 "misc: Add a CONTRIBUTING document > > This document details how to contribute to gem5 based on our new > contribution flow with git and gerrit. > > Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" > > > Diffs > ----- > > CONTRIBUTING.md PRE-CREATION > > Diff: http://reviews.gem5.org/r/3814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
