Jason Lowe-Power has uploaded this change for review. (
https://gem5-review.googlesource.com/7301
Change subject: dev: Fix wrong missing fallthrough
......................................................................
dev: Fix wrong missing fallthrough
The patch that added M5_FALLTHROUGH (5c41076bd7610 misc: Updates for gcc7.2
for x86) incorrectly assumed these missing fallthroughs should have been
breaks. Since we do not implement the keyboard output buffer any writes
should look like mouse output buffer writes. Otherwise, the panic on line
386 is triggered on the next write.
This patch changes the behavior back to what was happening before
5c41076bd7610. This code likely needs more updates to support keyboards
correctly.
Note: Without this patch Linux 4.14 won't boot.
Change-Id: I7de137b46cef00e6c1f1c14335cb52107cd7fe5b
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
---
M src/dev/x86/i8042.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/dev/x86/i8042.cc b/src/dev/x86/i8042.cc
index c5fca1b..de5e173 100644
--- a/src/dev/x86/i8042.cc
+++ b/src/dev/x86/i8042.cc
@@ -455,12 +455,12 @@
case WriteOutputPort:
warn("i8042 \"Write output port\" command not implemented.\n");
lastCommand = WriteOutputPort;
- break;
+ M5_FALLTHROUGH;
case WriteKeyboardOutputBuff:
warn("i8042 \"Write keyboard output buffer\" "
"command not implemented.\n");
lastCommand = WriteKeyboardOutputBuff;
- break;
+ M5_FALLTHROUGH;
case WriteMouseOutputBuff:
DPRINTF(I8042, "Got command to write to mouse output
buffer.\n");
lastCommand = WriteMouseOutputBuff;
--
To view, visit https://gem5-review.googlesource.com/7301
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7de137b46cef00e6c1f1c14335cb52107cd7fe5b
Gerrit-Change-Number: 7301
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Lowe-Power <ja...@lowepower.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
