Hello Gabe Black,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/7301
to look at the new patch set (#2).
Change subject: dev: Fix wrong missing fallthrough
......................................................................
dev: Fix wrong missing fallthrough
The patch that added M5_FALLTHROUGH (5c41076bd7610 misc: Updates for gcc7.2
for x86) incorrectly assumed these missing fallthroughs should have been
breaks. This "implements" the keyboard and mouse output buffers.
This patch changes the behavior back to what was happening before
5c41076bd7610. This code likely needs more updates to support keyboards
correctly.
Note: Without this patch Linux 4.14 won't boot.
Change-Id: I7de137b46cef00e6c1f1c14335cb52107cd7fe5b
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
---
M src/dev/x86/i8042.cc
1 file changed, 10 insertions(+), 3 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/7301
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7de137b46cef00e6c1f1c14335cb52107cd7fe5b
Gerrit-Change-Number: 7301
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
